[OpenMP] Update out of date documentation #142411
Conversation
jhuber6
requested review from
Meinersbur,
jdoerfert,
jplehr,
ronlieb and
shiltian
llvmbot
added
openmp:libomp
jdoerfert
left a comment
jdoerfert
left a comment
There was a problem hiding this comment.
Thanks for working on this. Some comments.
Summary: This deletes and changes somet things that are out of date or wrong and makes the recommended way to build more clear.
| - ``libomptarget.rtl.ve.so`` | ||
| - and others | ||
|
|
||
| - ``libompdevice.a``, the device-side OpenMP runtime. |
There was a problem hiding this comment.
We still have the .bc library IIRC?
There was a problem hiding this comment.
Yeah, I guess, it's more of an artifact.
Co-authored-by: Shilei Tian <[email protected]>
| you would like to use a newer GCC, set ``--gcc-install-dir=`` | ||
| to inform clang of the GCC installation you would like to use in the second stage. | ||
|
|
||
| Q: How can I include OpenMP offloading support in my CMake project? |
There was a problem hiding this comment.
Probably out of date and I haven't updated it in years. Maybe should delete that as well? Probably another patch, or just update it. Just not comfortable advertising it since no one uses it and it's massively out of date.
There was a problem hiding this comment.
I'm fine either way but to have one dangling is probably not a good idea.
There was a problem hiding this comment.
We either have an up-to-date document as well as an update-to-date find module, or don't have them at all. It is not a good idea to have an undocumented find module (which is probably out of date as well). The remove of the find module can be done in a separate PR though.
There was a problem hiding this comment.
We don't necessarily need documentation to point to it.
Summary: This deletes and changes somet things that are out of date or wrong and makes the recommended way to build more clear. --------- Co-authored-by: Shilei Tian <[email protected]>
7 participants
Summary:
This deletes and changes somet things that are out of date or wrong and
makes the recommended way to build more clear.